fix: avoid SSR requests in waitForRequestIdle #16246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
7 tasks
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on ✅ analogjs, astro, histoire, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, remix, sveltekit, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest |
sapphi-red
previously approved these changes
Mar 24, 2024
sapphi-red
added
p3-downstream-blocker
Co-authored-by: 翠 / green <green@sapphi.red>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16245
Tested with https://github.com/arxpoetica/inlang-sveltekit-vite-bug
The crawl end finder was only processing client requests before. When we moved to the server, we starting adding both client and SSR requests. The issue appears because the client and SSR requests share the same id space. The feature was added thinking on client requests only (see context at #16135). It should have been named
server.waitForClientRequestsIdle(id). This function will probably be moved to be environment specific if we move forward with the Environment API proposal.