Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not access document in /@vite/client when not defined #16318

Merged
merged 4 commits into from Apr 3, 2024
Merged

fix: do not access document in /@vite/client when not defined #16318

merged 4 commits into from Apr 3, 2024

Conversation

keyding
Copy link
Contributor

@keyding keyding commented Mar 31, 2024

Description

When using the vite-plugin-web-extension plugin for chrome extension development, the background requests http:/ /localhost:5173/@vite/client, background does not exist document.

overlay.ts

client.ts

@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 31, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red linked an issue Apr 3, 2024 that may be closed by this pull request
Uncaught ReferenceError: document is not defined #16277
Closed
7 tasks
@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release labels Apr 3, 2024
@sapphi-red sapphi-red changed the title fix: document not in background of chrome extension fix: do not access document in /@vite/client when not defined Apr 3, 2024
sapphi-red
sapphi-red previously approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a test and confirmed this fixes #16277

@sapphi-red
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 1960075: Open

✅ analogjs, astro, histoire, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, remix, sveltekit, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest

@patak-dev patak-dev enabled auto-merge (squash) April 3, 2024 12:33
@patak-dev patak-dev merged commit 646319c into vitejs:main Apr 3, 2024
10 checks passed
@keyding keyding deleted the patch/fix-in-chrome-extension branch April 3, 2024 13:22
@o-alexandrov o-alexandrov mentioned this pull request Apr 3, 2024
Open
patak-dev pushed a commit that referenced this pull request Apr 5, 2024
@keyding @sapphi-red @patak-dev
fix: do not access document in /@vite/client when not defined (#16318)
6c5536b 
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
@keyding keyding mentioned this pull request Apr 6, 2024
Closed
@sapphi-red sapphi-red mentioned this pull request Apr 8, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red left review comments

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught ReferenceError: document is not defined
3 participants
@keyding @sapphi-red @patak-dev