Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Terser type definitions (fix #17668) #17669

Merged
merged 3 commits into from
Jul 15, 2024
Merged

fix: update Terser type definitions (fix #17668) #17669

merged 3 commits into from
Jul 15, 2024

Conversation

luc122c
Copy link
Contributor

@luc122c luc122c commented Jul 12, 2024

Description

Fixes #17668 by copying over the latest types from https://github.com/terser/terser/blob/master/tools/terser.d.ts

Copy link

stackblitz bot commented Jul 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jul 15, 2024
@patak-dev
Copy link
Member

Except for exposing minify and minify_sync, this looks good to me.
Reference for the new added fields:

@patak-dev patak-dev requested a review from ArnaudBarre July 15, 2024 09:32
luc122c and others added 2 commits July 15, 2024 10:46
Remove exported functions

Co-authored-by: patak <583075+patak-dev@users.noreply.github.com>
@luc122c luc122c requested a review from patak-dev July 15, 2024 09:47
@patak-dev patak-dev enabled auto-merge (squash) July 15, 2024 11:39
@patak-dev patak-dev merged commit b723a75 into vitejs:main Jul 15, 2024
11 checks passed
@luc122c luc122c deleted the fix/update-terser-types branch July 15, 2024 11:48
@moshuying
Copy link

tks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terser options types are outdated
5 participants