Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue): allow to overwrite feature flags #2675

Merged
merged 1 commit into from Mar 29, 2021

Conversation

fahchen
Copy link
Contributor

@fahchen fahchen commented Mar 24, 2021

Description

Feature flags like __VUE_OPTIONS_API__ can't be overwritten, It seems to have been deleted in this commit a93ab23#diff-2b066c2eb45a74f1191f8796c6c76a93a7bc81417b11b8852e965aec86be2cc4 , this PR adds it back.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added p3-minor-bug An edge case that only affects very specific usage (priority) plugin: vue labels Mar 24, 2021
@patak-dev patak-dev merged commit a4acc16 into vitejs:main Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants