Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-vue): respect hmr: false server config #2797

Merged
merged 1 commit into from Mar 31, 2021
Merged

fix(plugin-vue): respect hmr: false server config #2797

merged 1 commit into from Mar 31, 2021

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Mar 31, 2021

Description

Fixes #2790

Additional context

N/A

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev added feat: hmr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) plugin: vue labels Mar 31, 2021
@patak-dev patak-dev merged commit 27e0c3f into vitejs:main Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
feat: hmr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[plugin-vue] should not inject HMR code if the server is started with hmr: false
3 participants
@sodatea @patak-dev @Shinigami92