Allow configurable bundles

[thekevinbrown]

Clear and concise description of the problem

• We use React PDF.
• It bundles in server side code which needs global and a few other things shimmed (e.g. react-pdf is not compatible without shims #3405)
• When using the workaround in the issue, the code works in development but does not work with a rollup production build.
  • This is because the stuff in index.html gets pulled into the user code bundle, which runs after the vendor bundle.
  • I created a local NPM module so this code would end up in the vendor bundle, and it does indeed end up in the vendor bundle then.
  • But importing it still happens in my user code, which is loaded after my vendor bundle, so we still get a Buffer is undefined error even when it's a part of the vendor bundle.

Suggested solution

Allow us to configure this polyfill to be injected at the top of the vendor bundle.

I couldn't find a rollup plugin (or vite plugin for that matter) that would allow this arbitrary code to get injected in the vendor bundle.

Happy to do this however I need to. I'm running out of options, and am thinking of gross things like a postinstall script to inject this at the top of the package if I can't find a way to configure Rollup to inject it.

Alternative

I'm also working on fixing React PDF itself so it works properly in modern environments and doesn't need all these shims, but I'm really struggling to even get a dev environment with a running example up for that package, so it'll be slow going. I think it'd be nice to allow developers to configure these types of workarounds when needed for other packages that they can't change.

Additional context

N/A

[bluwy]

Hi @thekevinbrown, is this feature request still needed? It sounds like a very niche case that should be fixed within react-pdf. Regarding the global shim, I think doing window.global = window should work too? If you put it in your entry file.

[thekevinbrown]

There was a bunch of workarounds required to make this work: https://github.com/exogee-technology/vite-plugin-shim-react-pdf

I still think it'd be useful to have the loading order of scripts in the production bundle the same as the dev bundle to minimise issues like this.

[bluwy]

The Vite plugin looks fine to me. It's intended to polyfill those nodejs modules manually if you use them.

Re loading order, is it similar to #7264? You can configure rollupOptions if you need something specific in your bundle. So I think this feature is already covered today. Can you clarify if there's anything else not covered yet, and what's the desired API?

[thekevinbrown]

Yup, that looks like a more concise version of what I'm asking for. I'll close this as a duplicate of #7264.