New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cache certificate #3642
feat: cache certificate #3642
Conversation
Thanks for the PR. We'll discuss this feature with Evan to get approval next week. |
@patak-js I think it is a good way that give some sub directories which do not clean by |
Yes, I agree. But I don't know if there is a need to add the fine-grained options at this point. But I think we may end up with |
We discussed this with Evan and we have his approval to merge this feature. But I just saw that there were some previous discussions about this in the past between Evan and @underfin in #276. Looks like the PR was closed after the v2 rewrite, but the feature was also considered good to have at that point. But there were some talks about storing IP addresses in the cert. @wmzy would you review that discussion? @underfin could you review this new PR? |
@patak-js This pr does not change the cert creation logic, but only add the cache to prevent the If that storing IP addresses in the cert is needed, it is better another pr. |
refact: empty catch style. Co-authored-by: Shinigami <chrissi92@hotmail.de>
Hi @patak-js @antfu ,can you help to merge this pr? |
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Description
If we enable https with the config below:
Browser will throw the
NET::ERR_CERT_AUTHORITY_INVALID
error ervery time vite restart.This PR cache the certificate to file system to avoid the boring error.
Additional context
I do not know if I can use the
config.cacheDir
directory to cache this.It seem that it only use for build data and maybe clean by
--force
option.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).