New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle imports from dot directories #3739
Conversation
Is there already a specific test that covers this change? Otherwise, could you add a test that fails without the change? |
Co-authored-by: patak <matias.capeletto@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is ok to merge this PR as is, but I see several other places in the code where path.startsWith('.')
is used. @hpx7 you may end up hitting other issues later for these paths. After this PR, maybe we could create a helper for this check and rework all the other conditions.
@patak-js with this change alone I am able to get my use cases working. Thanks! |
@patak-js @Shinigami92 are you able to merge this? |
question: Did it previously match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm
@Shinigami92 not sure if it would cause issues because |
Looks like a test flake, but I'm not sure |
I think you need to do a rebase. |
Good to merge now? |
Co-authored-by: patak <matias.capeletto@gmail.com>
Description
Fixes #2905
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).