Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt user when wrong build command is given #3754

Closed
ghost opened this issue Jun 10, 2021 · 1 comment
Closed

prompt user when wrong build command is given #3754

ghost opened this issue Jun 10, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Jun 10, 2021

Hey, thanks for all the work on Vite, I've been enjoying using it as a faster alternative. Sorry if this issue was ever brought up before; I dug around a bit but didn't see it here.

Clear and concise description of the problem

I was just building a project and ran 'npx vite run build' (because I'm still very used to Create React App) and Vite doesn't throw any sort of error. It will quickly just tell me the app is running locally, though when I go to Chrome it says: This localhost page can’t be found. It took me a minute to figure out I was supposed to type 'npx vite build' which of course, worked.

Suggested solution

I think a prompt here like "Did you mean npx vite build?" would be helpful and provide more context. Thanks for reading.

@underfin underfin added enhancement New feature or request and removed enhancement: pending triage labels Jun 14, 2021
@bluwy
Copy link
Member

bluwy commented Mar 11, 2022

Hi, we've discussed this in the team meeting and agreed to leave the behaviour as is for now as it's an edge case. If the command failed, vite --help should provide details on running things correctly.

There are ongoing PRs like cacjs/cac#135 that could help make the behavior clearer, but that would be a nice-to-have if it gets merge (and updated the dependency in Vite).

@bluwy bluwy closed this as completed Mar 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants