Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract config.base in importAnalysisBuild.ts #4096

Merged
merged 2 commits into from Jul 13, 2021
Merged

feat: extract config.base in importAnalysisBuild.ts #4096

merged 2 commits into from Jul 13, 2021

Conversation

hex-ci
Copy link
Contributor

@hex-ci hex-ci commented Jul 3, 2021

Description

issues: #4038

Extract config.base in importAnalysisBuild.ts to the preloadCode function.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@hex-ci
Extract config.base in importAnalysisBuild.ts
51d48f4 
Extract config.base in importAnalysisBuild.ts to the preloadCode function.
@Shinigami92 Shinigami92 linked an issue Jul 3, 2021 that may be closed by this pull request
The config.base option in the __vitePreload method generated during the build process should be extracted into a variable, not directly spliced into the file path. #4038
Closed
4 tasks
@patak-dev patak-dev added enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority) and removed enhancement: pending triage labels Jul 6, 2021
@hex-ci hex-ci requested a review from Shinigami92 July 13, 2021 05:43
@patak-dev patak-dev merged commit ab59598 into vitejs:main Jul 13, 2021
@hex-ci hex-ci deleted the patch-1 branch July 13, 2021 07:31
@vwkd vwkd mentioned this pull request Aug 25, 2021
Closed
7 tasks
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@hex-ci @aleclarson
feat: extract config.base in importAnalysisBuild.ts (vitejs#4096)
e9a6d27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
3 participants
@hex-ci @patak-dev @Shinigami92