fix: Vite cannot load configuration files in the link directory (#4180) #4181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
the
p3-minor-bug
|
@Shinigami92 what about check this PR? <3 |
Shinigami92
reviewed
Aug 20, 2021
packages/vite/src/node/config.ts
Outdated
| @@ -889,7 +889,7 @@ async function loadConfigFromBundledFile( | |||
| const extension = path.extname(fileName) | |||
| const defaultLoader = require.extensions[extension]! | |||
| require.extensions[extension] = (module: NodeModule, filename: string) => { | |||
| if (filename === fileName) { | |||
| if (filename === fs.realpathSync(fileName)) { | |||
There was a problem hiding this comment.
@patak-js Wasn't there something about realpathSync that it is bad? Cause it is slow or something?
There was a problem hiding this comment.
I don't know, we are not using it in the codebase. But we are using its async version realPath here:
There was a problem hiding this comment.
I think fs.realpathSync(fileName) will be called many times, if it is here and require exists inside the config.
How about caching it like this?
const realFileName = fs.realpathSync(fileName)
require.extensions[extension] = (module: NodeModule, filename: string) => {
if (filename === realFileName) {There was a problem hiding this comment.
That makes sense @sapphi-red, would you like to send a commit with that change to this PR directly?
patak-dev
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #4180
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).