feat: vite preview port is used automatically +1

[ygj6]

Description

related #4185
vite preview port is used automatically +1.

If the port is specified, it will not +1

{
  "scripts": {
    "preview": "vite preview --port 8080"
  }
}

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[Shinigami92]

Seems there were some changes in main, could you also do a git rebase -i main?

[ygj6]

Seems there were some changes in main, could you also do a git rebase -i main?

okay,already rebase

[Shinigami92]

@patak-js @ygj6 I will not have time for this today, but the requested changes should not stop us to merge it
It's just more nicer code refactoring requests

[patak-dev]

We aren't in a rush, but yes, I don't see that this particular refactoring is needed. We can explore that in another PR if you want.

But after testing the PR, maybe I missed a discussion but what is the reason to avoid mirroring the API of dev for preview regarding strictPort? In dev, port is a hint to where to start looking for a free port, and users need to use strictPort if they want to avoid changing it. Shouldn't preview work in the same way?

[ygj6]

We aren't in a rush, but yes, I don't see that this particular refactoring is needed. We can explore that in another PR if you want.

But after testing the PR, maybe I missed a discussion but what is the reason to avoid mirroring the API of dev for preview regarding strictPort? In dev, port is a hint to where to start looking for a free port, and users need to use strictPort if they want to avoid changing it. Shouldn't preview work in the same way?

I also think that both dev server and preview should use strictPort, but this is somewhat ambiguous with the current behavior.
For example, dev server and preview set the port number in different ways :
preview is --port: https://vitejs.dev/guide/static-deploy.html#testing-the-app-locally
dev server is server.port: https://vitejs.dev/config/#server-port

In addition, server.strictPort is placed under server: https://vitejs.dev/config/#server-strictport
should it be adjusted to a shared option? is strictPort,and modify the description.

[patak-dev]

You can also set the dev server port in the CLI https://github.com/vitejs/vite/blob/main/packages/vite/src/node/cli.ts#L67
And the --stricPort option is also present there.

We shouldn't use server.port and server.strictPort for preview as you said, this only affects the dev mode.

What I mean is that vite preview could work in the same way. We don't yet have a preview entry in the config, but at one point in the future we could add preview.port and preview.strictPort config options.
I think for this PR we could add a new --strictPort cli option in vite preview so both commands work in the same way. What do you think?

[ygj6]

The code is updated, please continue to help review, thank you.

[patak-dev]

Looks good @ygj6. We'll discuss this PR with the team this week to seek approval. Thanks!