page use vant and @vitejs/plugin-legacy plugin build.

[hxdyj]

Describe the bug

page use vant lib and @vitejs/plugin-legacy plugin build. run in chrome58 get Error SystemJS https://git.io/JvFET#3.
but page only use my component, it will be normal.

dist/assets not has file ./index-legacy.62d61901.js

Reproduction

https://github.com/hxdyj/vite-bug-legacy

System Info

System:
    OS: Linux 4.4 Debian GNU/Linux 10 (buster) 10 (buster)
    CPU: (12) x64 AMD Ryzen 5 PRO 4650U with Radeon Graphics
    Memory: 2.58 GB / 15.23 GB
    Container: Yes
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 15.11.0 - /usr/local/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 7.6.0 - /usr/local/bin/npm
  npmPackages:
    @vitejs/plugin-vue: ^1.2.5 => 1.2.5 
    vite: ^2.4.3 => 2.4.3

Used Package Manager

yarn

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

[hxdyj]

@nulladdict I guess this is plugin @vitejs/plugin-legacy bug.

[gaoxianglyx]

same error ！！！

[hxdyj]

same error ！！！

I find the way to build success，
But need modify plugin source code.

[RoxanneCIA]

same error ！！！

I find the way to build success，
But need modify plugin source code.

how to fix it？

[hxdyj]

index 44d1bbc..d626fdc 100644
--- a/node_modules/@vitejs/plugin-legacy/index.js
+++ b/node_modules/@vitejs/plugin-legacy/index.js
@@ -40,6 +40,7 @@ function viteLegacyPlugin(options = {}) {
   const facadeToModernPolyfillMap = new Map()
   const modernPolyfills = new Set()
   const legacyPolyfills = new Set()
+  let nullFacadeMap = {}
 
   if (Array.isArray(options.modernPolyfills)) {
     options.modernPolyfills.forEach((i) => {
@@ -93,12 +94,18 @@ function viteLegacyPlugin(options = {}) {
       if (config.build.minify === 'esbuild') {
         throw new Error(
           `Can't use esbuild as the minifier when targeting legacy browsers ` +
-            `because esbuild minification is not legacy safe.`
+          `because esbuild minification is not legacy safe.`
         )
       }
     },
 
     async generateBundle(opts, bundle) {
+      for (const name in bundle) {
+        let chunk = bundle[name]
+        if (chunk.type === 'chunk' && !chunk.facadeModuleId) {
+          nullFacadeMap[chunk.fileName] = chunk
+        }
+      }
       if (!isLegacyBundle(bundle, opts)) {
         if (!modernPolyfills.size) {
           return
@@ -399,6 +406,7 @@ function viteLegacyPlugin(options = {}) {
     },
 
     generateBundle(opts, bundle) {
+      Object.assign(bundle, nullFacadeMap)
       if (isLegacyBundle(bundle, opts)) {
         // avoid emitting duplicate assets
         for (const name in bundle) {
@@ -434,7 +442,7 @@ function viteLegacyPlugin(options = {}) {
       if (envInjectionFailed) {
         config.logger.warn(
           `[@vitejs/plugin-legacy] import.meta.env.LEGACY was not injected due ` +
-            `to incompatible vite version (requires vite@^2.0.0-beta.69).`
+          `to incompatible vite version (requires vite@^2.0.0-beta.69).`
         )
       }
     }

modify node_modules plugin index.js

[Shinigami92]

@hxdyj Is there a reason why you didn't propose a PR?

[hxdyj]

@hxdyj Is there a reason why you didn't propose a PR?

I'am not very familiar with rollup, just fix it, but my way are not good.

[aladdin-add]

same issue with latest vite and legacy-plugin.

[alvc666]

index 44d1bbc..d626fdc 100644
--- a/node_modules/@vitejs/plugin-legacy/index.js
+++ b/node_modules/@vitejs/plugin-legacy/index.js
@@ -40,6 +40,7 @@ function viteLegacyPlugin(options = {}) {
   const facadeToModernPolyfillMap = new Map()
   const modernPolyfills = new Set()
   const legacyPolyfills = new Set()
+  let nullFacadeMap = {}
 
   if (Array.isArray(options.modernPolyfills)) {
     options.modernPolyfills.forEach((i) => {
@@ -93,12 +94,18 @@ function viteLegacyPlugin(options = {}) {
       if (config.build.minify === 'esbuild') {
         throw new Error(
           `Can't use esbuild as the minifier when targeting legacy browsers ` +
-            `because esbuild minification is not legacy safe.`
+          `because esbuild minification is not legacy safe.`
         )
       }
     },
 
     async generateBundle(opts, bundle) {
+      for (const name in bundle) {
+        let chunk = bundle[name]
+        if (chunk.type === 'chunk' && !chunk.facadeModuleId) {
+          nullFacadeMap[chunk.fileName] = chunk
+        }
+      }
       if (!isLegacyBundle(bundle, opts)) {
         if (!modernPolyfills.size) {
           return
@@ -399,6 +406,7 @@ function viteLegacyPlugin(options = {}) {
     },
 
     generateBundle(opts, bundle) {
+      Object.assign(bundle, nullFacadeMap)
       if (isLegacyBundle(bundle, opts)) {
         // avoid emitting duplicate assets
         for (const name in bundle) {
@@ -434,7 +442,7 @@ function viteLegacyPlugin(options = {}) {
       if (envInjectionFailed) {
         config.logger.warn(
           `[@vitejs/plugin-legacy] import.meta.env.LEGACY was not injected due ` +
-            `to incompatible vite version (requires vite@^2.0.0-beta.69).`
+          `to incompatible vite version (requires vite@^2.0.0-beta.69).`
         )
       }
     }

modify node_modules plugin index.js

this is work for me, same problem here

[jessechengzhu]

I had the same problem before，and i tried use VueRouter without dynamic import() then solved it.
Now when I upgrade some dependencies related to vite, the problem is solved automatically, and I can't find the reason😂

[bluwy]

Hi @hxdyj. I tested the repro locally and this seems to be fixed now. I dont see any files missing after upgrading Vite to 2.8.6 and plugin-legacy to 1.7.1. Can you confirm if this is fixed for you?

[hxdyj]

Hi @hxdyj. I tested the repro locally and this seems to be fixed now. I dont see any files missing after upgrading Vite to 2.8.6 and plugin-legacy to 1.7.1. Can you confirm if this is fixed for you?

already fixed. Thank you!!