Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: surface exception when failing to resolve package entry #4426

Merged
merged 1 commit into from Aug 16, 2021

Conversation

benmccann
Copy link
Collaborator

Description

resolveExports throws an exception when trying to SSR Firebase. This method had a Failed to resolve entry for package error message, but it wouldn't get triggered if there's an exception

Additional context

Firebase has long been the #1 library that people complain about using with SvelteKit. I finally got tired of people complaining about it and decided to dig into it. It turns out that there was an exception being thrown and swallowed. This will allow some details to be printed to the console to reveal what the issue is (#4425)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-dev
patak-dev previously approved these changes Jul 29, 2021
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants