fix: CSS dependencies are tracked incorrectly when base is set

[ElMassimo]

Description

CSS file dependencies are being tracked incorrectly when the base configuration option is set—URLs are being prefixed with base in some scenarios.

URLs in the module graph are normalized and are never prefixed with base, and as a result changes to those files are not causing the CSS module to be invalidated.

This pull request ensures the base is removed before passing it to ensureEntryFromUrl which is not base-aware.

Additional context

The bug was introduced in #4267, released in 2.4.3.

Among other potential bugs, this causes Tailwind CSS in JIT mode to stop working as expected when base is specified, because changes to HTML or JS files do not match the module graph file names, and as a result CSS is not invalidated when a change occurs.

See tailwindlabs/tailwindcss#4978 (comment) for more context.

What is the purpose of this pull request?

• Bug fix

[Shinigami92]

Looks like a weird solution, but if it works, it works

[ElMassimo]

Yeah, I'm not convinced that using fileToUrl as added in #4267 is the way to go, but there's no other "normalize" function that is public and can handle all the edge cases.

Perhaps it could be wrapped into fileToModuleGraphUrl and remove the base there instead, but for now it's the only place where it's used like this.

[patak-dev]

I think the refactoring mentioned by @ElMassimo should be done, but we could get this fix in the meantime.

[sebastiaanluca]

Is it possible this has broken again somehow? Using vite 2.6.3 and Tailwind (v2 or 3) breaks its JIT mode. Downgrading to Vite 2.4.2 (as suggested in tailwindlabs/tailwindcss#4978 (comment)) resolves the issue.

[patak-dev]

@sebastiaanluca would you create an issue with a reproduction to track this?

[sebastiaanluca]

Need to do the same for the other ticket, so I'll try and set that up one of these days 👍