fix(scan): do not match 'export default' in comments #4602
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4598
Description
If the script code happens to contain
export default
in comments, thenexport default {}
will not be added at the end of line.Just like the issue #4598 :
vite/packages/vite/src/node/optimizer/scan.ts
Lines 241 to 243 in eb2e41b
My current solution refers to PR: #4088 . Empty the singleline & multiline comments first, using the
code
without comments to match.Additional context
I have considered adding test cases, but meanwhile I noticed that current unit tests are only for regular expressions, so I don't add them at the moment.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).