Public dir warning does not match the configured public dir

[dd-jonas]

Describe the bug

I use routes in my SPA that start with /public, which triggers this warning:

files in the public directory are served at the root path.
Instead of /public/foo, use /foo.

I tried to update the publicDir in the vite configuration, but the warning remains. Regardless of my custom routes, the warning should match the configured public dir. This also means that renaming the publicDir and referencing it by it's new name does not trigger this warning, while it should.

Reproduction

https://github.com/dd-jonas/vite-public-dir-warning-issue

The repro shows the warning being triggered by the '/public/foo' route that is unrelated to the public folder (which has been renamed to 'static'). It also shows the warning not being triggered when linking a manifest.json and using the publicDir in the path.

System Info

System:
    OS: Windows 10 10.0.19043
    CPU: (12) x64 AMD Ryzen 5 1600X Six-Core Processor
    Memory: 11.02 GB / 15.95 GB

Binaries:
    Node: 14.15.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.5 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 6.14.8 - C:\Program Files\nodejs\npm.CMD

Browsers:
    Chrome: 92.0.4515.131
    Edge: Spartan (44.19041.1023.0), Chromium (92.0.902.73)
    Internet Explorer: 11.0.19041.906

Used Package Manager

yarn

Logs

$ vite --debug
  vite:config bundled config file loaded in 83ms +0ms
  vite:config using resolved config: {
  vite:config   publicDir: 'D:\\Documenten\\Sites\\vite-warning-repro\\static',
  vite:config   build: {
  vite:config     target: [ 'es2019', 'edge88', 'firefox78', 'chrome87', 'safari13.1' ],
  vite:config     polyfillModulePreload: true,
  vite:config     outDir: 'build',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     sourcemap: false,
  vite:config     rollupOptions: {},
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     dynamicImportVarsOptions: { warnOnError: true, exclude: [Array] },
  vite:config     minify: 'terser',
  vite:config     terserOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     brotliSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null
  vite:config   },
  vite:config   plugins: [
  vite:config     'vite:pre-alias',
  vite:config     'alias',
  vite:config     'vite:react-jsx',
  vite:config     'react-refresh',
  vite:config     'vite:modulepreload-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:client-inject',
  vite:config     'vite:import-analysis'
  vite:config   ],
  vite:config   server: { fs: { strict: undefined, allow: [Array] } },
  vite:config   resolve: { dedupe: [ 'react', 'react-dom' ], alias: [ [Object], [Object] ] },
  vite:config   configFile: 'D:/Documenten/Sites/vite-warning-repro/vite.config.js',
  vite:config   configFileDependencies: [ 'vite.config.js' ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     server: {}
  vite:config   },
  vite:config   root: 'D:/Documenten/Sites/vite-warning-repro',
  vite:config   base: '/',
  vite:config   cacheDir: 'D:\\Documenten\\Sites\\vite-warning-repro\\node_modules\\.vite',
  vite:config   command: 'serve',
  vite:config   mode: 'development',
  vite:config   isProduction: false,
  vite:config   env: { BASE_URL: '/', MODE: 'development', DEV: true, PROD: false },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen],
  vite:config     hasErrorLogged: [Function: hasErrorLogged]
  vite:config   },
  vite:config   createResolver: [Function: createResolver],
  vite:config   optimizeDeps: { esbuildOptions: { keepNames: undefined } }
  vite:config } +4ms
  vite:deps Hash is consistent. Skipping. Use --force to override. +0ms

  vite v2.5.0 dev server running at:

  > Local: http://localhost:3000/
  > Network: use `--host` to expose

  ready in 273ms.

  vite:time 1ms   / +0ms
files in the public directory are served at the root path.
Instead of /public/foo, use /foo.
  vite:resolve 2ms   /public/foo -> null +0ms
  vite:spa-fallback Rewriting GET /public/foo to /index.html +0ms
  vite:time 25ms  /index.html +33ms
  vite:resolve 0ms   D:\Documenten\Sites\vite-warning-repro\node_modules\vite\dist\client\client.mjs -> D:/Documenten/Sites/vite-warning-repro/node_modules/vite/dist/client/client.mjs +35ms
  vite:resolve 1ms   /@vite/client -> D:/Documenten/Sites/vite-warning-repro/node_modules/vite/dist/client/client.mjs +1ms
  vite:load 1ms   [fs] /@vite/client +0ms
  vite:resolve 1ms   D:\Documenten\Sites\vite-warning-repro\node_modules\vite\dist\client\env.mjs -> D:/Documenten/Sites/vite-warning-repro/node_modules/vite/dist/client/env.mjs +12ms
  vite:resolve 1ms   @vite/env -> D:/Documenten/Sites/vite-warning-repro/node_modules/vite/dist/client/env.mjs +0ms
  vite:resolve 2ms   /node_modules/vite/dist/client/env.mjs -> D:/Documenten/Sites/vite-warning-repro/node_modules/vite/dist/client/env.mjs +2ms
  vite:transform 10ms  /@vite/client +0ms
  vite:time 18ms  /@vite/client +31ms
  vite:resolve 0ms   /src/index.jsx -> D:/Documenten/Sites/vite-warning-repro/src/index.jsx +4ms
  vite:load 1ms   [fs] /src/index.jsx +17ms
  vite:load 0ms   [plugin] /@react-refresh +257ms
  vite:rewrite 1ms   [no imports] /@react-refresh +0ms
  vite:transform 1ms   /@react-refresh +263ms
  vite:time 3ms   /@react-refresh +263ms
  vite:resolve 0ms   react -> D:/Documenten/Sites/vite-warning-repro/node_modules/.vite/react.js?v=532b7f78&es-interop +264ms
  vite:resolve 0ms   /node_modules/.vite/react.js?v=532b7f78&es-interop -> D:/Documenten/Sites/vite-warning-repro/node_modules/.vite/react.js?v=532b7f78&es-interop +0ms
  vite:resolve 0ms   react-dom -> D:/Documenten/Sites/vite-warning-repro/node_modules/.vite/react-dom.js?v=532b7f78&es-interop +5ms
  vite:resolve 0ms   /node_modules/.vite/react-dom.js?v=532b7f78&es-interop -> D:/Documenten/Sites/vite-warning-repro/node_modules/.vite/react-dom.js?v=532b7f78&es-interop +0ms
  vite:resolve 1ms   ./App -> D:/Documenten/Sites/vite-warning-repro/src/App.jsx +2ms
  vite:resolve 0ms   /src/App.jsx -> D:/Documenten/Sites/vite-warning-repro/src/App.jsx +0ms
  vite:resolve 0ms   /node_modules/.vite/react.js?v=532b7f78 -> D:/Documenten/Sites/vite-warning-repro/node_modules/.vite/react.js?v=532b7f78 +1ms
  vite:resolve 0ms   /node_modules/.vite/react-dom.js?v=532b7f78 -> D:/Documenten/Sites/vite-warning-repro/node_modules/.vite/react-dom.js?v=532b7f78 +0ms
  vite:transform 270ms /src/index.jsx +13ms
  vite:time 274ms /src/index.jsx +12ms
  vite:load 0ms   [fs] /node_modules/vite/dist/client/env.mjs +16ms
  vite:rewrite 0ms   [no imports] node_modules\vite\dist\client\env.mjs +16ms
  vite:transform 1ms   /node_modules/vite/dist/client/env.mjs +4ms
  vite:time 3ms   /node_modules/vite/dist/client/env.mjs +4ms
  vite:load 0ms   [fs] /src/App.jsx +6ms
  vite:resolve 0ms   react-router-dom -> D:/Documenten/Sites/vite-warning-repro/node_modules/.vite/react-router-dom.js?v=532b7f78 +38ms
  vite:resolve 0ms   /node_modules/.vite/react-router-dom.js?v=532b7f78 -> D:/Documenten/Sites/vite-warning-repro/node_modules/.vite/react-router-dom.js?v=532b7f78 +0ms
  vite:hmr [self-accepts] src\App.jsx +0ms
  vite:transform 33ms  /src/App.jsx +38ms
  vite:time 36ms  /src/App.jsx +39ms
  vite:time 3ms   /favicon.ico +67ms
  vite:time 1ms   /static/manifest.json +307ms

Validations

• Read the Contributing Guidelines.
• Follow our Code of Conduct
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.