Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): minify css will transform rgba to #rrggbbaa #4658

Merged
merged 2 commits into from Aug 19, 2021
Merged

fix(css): minify css will transform rgba to #rrggbbaa #4658

merged 2 commits into from Aug 19, 2021

Conversation

y1d7ng
Copy link
Contributor

@y1d7ng y1d7ng commented Aug 19, 2021 •
edited

Description

fix #4650

Additional context

esbuild will decide whether to convert rgba to #rrggbbaa according to the target, related issue

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Ttou
Copy link

Ttou commented Aug 19, 2021

this fix will work

patak-dev
patak-dev previously approved these changes Aug 19, 2021
View reviewed changes
@Shinigami92 Shinigami92 added p3-minor-bug An edge case that only affects very specific usage (priority) feat: css labels Aug 19, 2021
Shinigami92
Shinigami92 previously approved these changes Aug 19, 2021
View reviewed changes
@y1d7ng y1d7ng dismissed stale reviews from Shinigami92 and patak-dev via 0a1822d August 19, 2021 14:23
@patak-dev patak-dev merged commit 632a50a into vitejs:main Aug 19, 2021
@y1d7ng y1d7ng deleted the hotfix-4650 branch August 19, 2021 14:43
@sodatea sodatea mentioned this pull request Sep 29, 2021
Merged
9 tasks
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@y1d7ng @aleclarson
fix(css): minify css will transform rgba to #rrggbbaa (vitejs#4658)
545a60d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Awaiting requested review from Shinigami92

Assignees
No one assigned
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minify css will transform rgba to #rrggbbaa
4 participants
@y1d7ng @Ttou @patak-dev @Shinigami92