Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent pre-bundling @vite/client and @vite/env #4716

Merged
merged 2 commits into from Aug 25, 2021
Merged

fix: prevent pre-bundling @vite/client and @vite/env #4716

merged 2 commits into from Aug 25, 2021

Conversation

tmkx
Copy link
Contributor

@tmkx tmkx commented Aug 24, 2021

Description

Pre-bundling will not replace magic constants, so inner deps should not be pre-bundled.

Additional context


What is the purpose of this pull request?

  • Bug fix

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed as a valid fix for antfu/vitesse-webext#19 (comment)

@patak-dev patak-dev changed the title fix(vite): prevent pre-bundling @vite/client and @vite/env fix: prevent pre-bundling @vite/client and @vite/env Aug 25, 2021
@patak-dev patak-dev merged commit e8c1906 into vitejs:main Aug 25, 2021
@tmkx tmkx deleted the fix/optimize-exclude branch August 25, 2021 07:20
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants