Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't transform new URL(url, import.meta.url) in comments #4732

Merged
merged 1 commit into from Aug 30, 2021
Merged

fix: don't transform new URL(url, import.meta.url) in comments #4732

merged 1 commit into from Aug 30, 2021

Conversation

y1d7ng
Copy link
Contributor

@y1d7ng y1d7ng commented Aug 25, 2021

Description

fix #4308

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Shinigami92
Shinigami92 previously approved these changes Aug 25, 2021
View reviewed changes
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Aug 25, 2021
@benmccann
Copy link
Collaborator

@OneNail this PR will need to be rebased

@y1d7ng
Copy link
Contributor Author

y1d7ng commented Aug 28, 2021

@OneNail this PR will need to be rebased

Thanks for reminding

patak-dev
patak-dev approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick to replace the content of the comments with empty space!

@patak-dev patak-dev merged commit bf0b631 into vitejs:main Aug 30, 2021
@y1d7ng y1d7ng deleted the hotfix/4308 branch August 30, 2021 07:31
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@y1d7ng @aleclarson
fix: don't transform new URL(url, import.meta.url) in comments (vitej…
74199ed 
…s#4732)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

asset-import-meta-url cant resolve non existing paths
4 participants
@y1d7ng @benmccann @patak-dev @Shinigami92