Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the base is duplicated in importAnalysisBuild.ts #4740

Merged
merged 2 commits into from Sep 13, 2021

Conversation

hex-ci
Copy link
Contributor

@hex-ci hex-ci commented Aug 26, 2021

Description

Fix a problem that the base is duplicated when importing css files dynamically.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@hex-ci hex-ci changed the title Fix a problem that the base is duplicated. fix: the base is duplicated in importAnalysisBuild.ts Aug 26, 2021
@crcong
Copy link
Contributor

crcong commented Aug 26, 2021

I think we can add some test cases to prevent regression.

@hex-ci
Copy link
Contributor Author

hex-ci commented Aug 26, 2021

@crcong Yes, there may be a lack of test cases, which is a small problem caused by the time difference of PR.

@patak-dev
Copy link
Member

Thanks for tracking this down @hex-ci @crcong!
I think it would be good to add the test case as part of this PR as you suggested

@hex-ci
Copy link
Contributor Author

hex-ci commented Sep 8, 2021

@patak-js I fixed the problem of dynamically importing css test cases. Now the test cases can correctly judge whether css is successfully imported.

@hex-ci
Copy link
Contributor Author

hex-ci commented Sep 10, 2021

cc @antfu @Shinigami92

@hex-ci
Copy link
Contributor Author

hex-ci commented Sep 11, 2021

This is a serious bug that seems to affect more and more people who use dynamically imported .css files. @patak-js

@patak-dev patak-dev merged commit 7e929ae into vitejs:main Sep 13, 2021
@hex-ci hex-ci deleted the patch-1 branch September 13, 2021 14:22
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants