Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): resolve .cjs file extensions #4772

Merged
merged 1 commit into from Aug 30, 2021
Merged

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Aug 28, 2021

fix #4452

Description

Currently vite uses require() to import module in ssr mode.

const mod = require(resolve(id, importer, root))

According to nodejs' doc, It is not possible to require() files that have the .mjs extension. Attempting to do so will throw an error.
So we can only include the .cjs file extension here.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added feat: ssr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Aug 30, 2021
@patak-dev patak-dev merged commit 96712ad into vitejs:main Aug 30, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssr: resolve also .cjs and .mjs file extensions
3 participants