Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sometimes THIS_IS_UNDEFINED warnings were still shown #4844

Merged
merged 1 commit into from Sep 6, 2021

Conversation

yarsky-tgz
Copy link
Contributor

@yarsky-tgz yarsky-tgz commented Sep 4, 2021

Description

Using current latest (v.2.5.3) vite for building our project i was getting lot of The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten errors in console.

I've dived into sources, and found that here we have logic for filtering out such warnings, but here no onwarn provided at all.

So I've fixed situation by reusage at node/plugins/worker function onRollupWarning exported from ./node/build.

Using npm pack I've tried it on my side already, and having no more THIS_IS_UNDEFINED warnings at console during building, as expected

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@yarsky-tgz yarsky-tgz changed the title fix: use configured handler for worker's rollup warning fix: sometimes THIS_IS_UNDEFINED warnings were still shown Sep 5, 2021
@antfu antfu merged commit 8d956f6 into vitejs:main Sep 6, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants