Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): loadPreprocessor tolerate require.resolve.paths not exists #4853

Merged
merged 1 commit into from Sep 6, 2021

Conversation

antfu
Copy link
Member

@antfu antfu commented Sep 6, 2021

Description

In some cases, require.resolve.paths does not exist (not yet sure why, might be some registers) and causing the package failed to resolve. This PR fix it as a workaround.

Additional context

Close #4557
Close nuxt/vite#162

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit c588b8f into vitejs:main Sep 6, 2021
@antfu antfu deleted the fix/loadPreprocessor branch September 6, 2021 11:16
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite 2.4.x cannot find SASS when using Nuxt-Vite sass failed to compile
2 participants