Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlay): handle missing customElements #4856

Merged
merged 1 commit into from Sep 6, 2021
Merged

fix(overlay): handle missing customElements #4856

merged 1 commit into from Sep 6, 2021

Conversation

daaku
Copy link
Contributor

@daaku daaku commented Sep 6, 2021

Description

My environment doesn't have customElements. I set server.hmr.overlay to false, but importing overlay immediately triggers this error, making the configuration moot for this case.

Additional context

In theory a better fix might be to use an async import for overlay. async imports potentially have other issues depending on the build/env so I avoided using that approach.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@daaku daaku changed the title overlay: handle missing customElements fix: overlay: handle missing customElements Sep 6, 2021
@antfu antfu changed the title fix: overlay: handle missing customElements fix(overlay): handle missing customElements Sep 6, 2021
@antfu antfu merged commit e5b472d into vitejs:main Sep 6, 2021
@daaku
Copy link
Contributor Author

daaku commented Sep 6, 2021

Sweet - that was fast.

aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants