Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): return sourcemap in vite:css transform #4880

Merged
merged 1 commit into from Sep 13, 2021

Conversation

dominikg
Copy link
Contributor

@dominikg dominikg commented Sep 8, 2021

Description

return actual sourcemap for css transform instead of a dummy

Additional context

may fix #649

Note i didn't do any further analysis besides running the tests, but this seems like a trivial change for the better, can't get more broken than that dummy.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@dominikg
Copy link
Contributor Author

dominikg commented Sep 8, 2021

There was a previous attempt at this aimed at vite1 that was closed #659 and there may be other things to consider that i missed.
Thanks to @bluwy who reminded me about this.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this wasn't caught before by someone

@Shinigami92 Shinigami92 added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Sep 8, 2021
@antfu antfu merged commit 015290a into vitejs:main Sep 13, 2021
@hex-ci
Copy link
Contributor

hex-ci commented Sep 15, 2021

This PR seems to have an impact on the vite-plugin-vue2 plugin. If you upgrade to Vite 2.5.7, a "Sourcemap is likely to be incorrect" warning will be reported during build. If you downgrade to Vite 2.5.6, there will be no warning, only downgrade vite-plugin-vue2 There are always warnings. I haven't figured out the specific reason, and I need help, thank you.

@patak-dev
Copy link
Member

@hex-ci did you open an issue in vite-plugin-vue2? Maybe this is something to be solved there? Please link the issue for reference here

@hex-ci
Copy link
Contributor

hex-ci commented Sep 15, 2021

@hex-ci did you open an issue in vite-plugin-vue2? Maybe this is something to be solved there? Please link the issue for reference here

I created an issue: underfin/vite-plugin-vue2#132

@hex-ci
Copy link
Contributor

hex-ci commented Sep 16, 2021

@patak-js The problem mentioned in #4939 seems to affect not only Vue 2, but also Vue 3.

@patak-dev
Copy link
Member

Oh, I think you should also open an issue here to track it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The css sourceMap not work
6 participants