fix(esbuildDepPlugin): externalize built-in module during SSR

[ygj6]

fix #4700

Description

esbuildDepPlugin use path.resolve to resolve built-in module during SSR cause error, it should externalize built-in module during SSR

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[patak-dev]

@ygj6 do you think it is possible to add a test case for this? @bluwy maybe you could also check this one?

[bluwy]

LGTM. One thing to note is that Vite already handles this in its resolve plugin:

vite/packages/vite/src/node/plugins/resolve.ts

Lines 226 to 229 in ce29273

	// node built-ins.
	// externalize if building for SSR, otherwise redirect to empty module
	if (isBuiltin(id)) {
	if (ssr) {

But using createResolver swallows the external info:

vite/packages/vite/src/node/config.ts

Line 406 in ce29273

return (await container.resolveId(id, importer, undefined, ssr))?.id

So this makes the change necessary, unless we support the node: prefix in the future.

[patak-dev]

Ok, thanks for tge revies @bluwy. Lets merge this one, it would be good to issue a PR with a new test case also

[ygj6]

Ok, thanks for tge revies @bluwy. Lets merge this one, it would be good to issue a PR with a new test case also

Great! Thanks for your reviews. I will do it.