(bug: ssr) NodeRequire is undefined when call ssrLoadmodule in entry-server file

[zhangyuang]

Describe the bug

ssrModuleLoader function only inject NodeJs.Global in context but not NodeRequire which cause require is not defined error occur when evaluating !entry module. I can't determine whether vite do this on purpose.here is a pr maybe fix the problem

Reproduction

https://github.com/zhangyuang/vite-ssr-error-require

$ yarn && yarn dev &&  curl http://127.0.0.1:3000/

System Info

$ npx envinfo --system --npmPackages '{vite,@vitejs/*}' --binaries --browsers

  System:
    OS: macOS 10.15.4
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 1.44 GB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 14.17.2 - ~/.nvm/versions/node/v14.17.2/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 95.0.4638.54
    Safari: 13.1
  npmPackages:
    @vitejs/plugin-vue: ^1.0.0 => 1.9.3
    @vitejs/plugin-vue-jsx: ^1.0.0 => 1.2.0
    vite: ^2.6.11 => 2.6.11

Used Package Manager

yarn

Logs

curl http://127.0.0.1:3000/
ReferenceError: require is not defined
    at /src/entry-server.js:5:13
    at async instantiateModule (/Users/yuuang/Desktop/ssr-vue/node_modules/vite/dist/node/chunks/dep-92cbd8f1.js:66520:9)%

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[zhangyuang]

#5425

[sodatea]

As far as I know, in a Node.js ES module you need to use createRequire to safely create a require function with the right context.
So I think Vite is working as expected here.

[zhangyuang]

As far as I know, in a Node.js ES module you need to use createRequire to safely create a require function with the right context. So I think Vite is working as expected here.

What do you mean is use createRequire to create require rather than inject require in new Function in vite?

[sodatea]

https://nodejs.org/api/esm.html#no-require-exports-or-moduleexports

[zhangyuang]

Get

[bluwy]

I'm not sure if this is something we should support. I remember in a team meeting before that ssrLoadModule is used to load an ESM module, hence its function name. And there's no require() in ESM. So I don't think this is something we want. Leaving this open if others have some thoughts on this.