Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.7.0-beta.2] _interopRequireDefault3 is not a function #5798

Closed
IanVS opened this issue Nov 22, 2021 · 2 comments · Fixed by #5872
Closed

[2.7.0-beta.2] _interopRequireDefault3 is not a function #5798

IanVS opened this issue Nov 22, 2021 · 2 comments · Fixed by #5872
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Milestone
2.7

Comments

@IanVS
Copy link
Contributor

IanVS commented Nov 22, 2021

Describe the bug

I attempted to update from vite 2.6.x to 2.7.0 beta, and my tests began to fail with:

TypeError: _interopRequireDefault3 is not a function
        at node_modules/@testing-library/jest-dom/dist/utils.js (node_modules/.cache/vite/@testing-library_jest-dom.js:3794:19)
        at __require2 (node_modules/.cache/vite/chunk-UC7LELEO.js:48:44)
        at node_modules/@testing-library/jest-dom/dist/to-be-in-the-dom.js (node_modules/.cache/vite/@testing-library_jest-dom.js:3971:18)
        at __require2 (node_modules/.cache/vite/chunk-UC7LELEO.js:48:44)
        at node_modules/@testing-library/jest-dom/dist/matchers.js (node_modules/.cache/vite/@testing-library_jest-dom.js:15699:25)
        at __require2 (node_modules/.cache/vite/chunk-UC7LELEO.js:48:44)
        at node_modules/@testing-library/jest-dom/dist/extend-expect.js (node_modules/.cache/vite/@testing-library_jest-dom.js:15730:46)
        at __require2 (node_modules/.cache/vite/chunk-UC7LELEO.js:48:44)
        at node_modules/@testing-library/jest-dom/dist/index.js (node_modules/.cache/vite/@testing-library_jest-dom.js:15777:5)
        at __require2 (node_modules/.cache/vite/chunk-UC7LELEO.js:48:44)

I traced this down to starting in beta.2.

Reproduction

https://stackblitz.com/edit/vite-a7kdqq?file=package.json

Note, you'll get an error in the console. If you change vite to use 2.7.0-beta.1 and re-install / restart, the app will load up as normal.

System Info

System:
    OS: macOS 11.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 2.74 GB / 32.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.4.0 - ~/.nvm/versions/node/v16.4.0/bin/node
    Yarn: 1.22.15 - ~/.yarn/bin/yarn
    npm: 8.1.3 - ~/.nvm/versions/node/v16.4.0/bin/npm
  Browsers:
    Brave Browser: 95.1.31.91
    Firefox: 94.0.1
    Safari: 15.0
  npmPackages:
    @vitejs/plugin-react: ^1.1.0 => 1.1.0
    vite: ^2.7.0-beta.2 => 2.7.0-beta.2

Used Package Manager

npm

Logs

❯ npm run dev -- --debug
$ vite --debug
  vite:config bundled config file loaded in 233.10ms +0ms
  vite:config using resolved config: {
  vite:config   optimizeDeps: {
  vite:config     include: [ '@testing-library/jest-dom', 'expect' ],
  vite:config     esbuildOptions: { keepNames: undefined, preserveSymlinks: undefined }
  vite:config   },
  vite:config   define: {
  vite:config     'process.env': {
  vite:config       COLORTERM: 'truecolor',
  vite:config       TERM: 'xterm-256color',
  vite:config       LSCOLORS: 'ExGxBxDxCxEgEdxbxgExEx',
  vite:config       PATH: '/home/projects/vite-a7kdqq/node_modules/.bin:/home/projects/node_modules/.bin:/home/node_modules/.bin:/node_modules/.bin:/bin:/usr/bin:/usr/local/bin',
  vite:config       HOME: '/home',
  vite:config       SHELL: '/bin/jsh',
  vite:config       HISTFILE: '/home/.jsh_history',
  vite:config       TMPDIR: '/tmp',
  vite:config       CHROME_BIN: '/usr/local/bin/google-chrome',
  vite:config       NEXT_TELEMETRY_DISABLED: '1',
  vite:config       ESBUILD_WORKER_THREADS: '0',
  vite:config       PKG_MANAGER: 'npm',
  vite:config       DEBUG: 'vite:*'
  vite:config     }
  vite:config   },
  vite:config   server: { fs: { strict: true, allow: [Array], deny: [Array] } },
  vite:config   configFile: '/home/projects/vite-a7kdqq/vite.config.js',
  vite:config   configFileDependencies: [ 'vite.config.js' ],
  vite:config   inlineConfig: {
  vite:config     root: undefined,
  vite:config     base: undefined,
  vite:config     mode: undefined,
  vite:config     configFile: undefined,
  vite:config     logLevel: undefined,
  vite:config     clearScreen: undefined,
  vite:config     server: { fs: [Object] }
  vite:config   },
  vite:config   root: '/home/projects/vite-a7kdqq',
  vite:config   base: '/',
  vite:config   resolve: { dedupe: undefined, alias: [ [Object], [Object] ] },
  vite:config   publicDir: '/home/projects/vite-a7kdqq/public',
  vite:config   cacheDir: '/home/projects/vite-a7kdqq/node_modules/.vite',
  vite:config   command: 'serve',
  vite:config   mode: 'development',
  vite:config   isProduction: false,
  vite:config   plugins: [
  vite:config     'vite:pre-alias',
  vite:config     'alias',
  vite:config     'vite:modulepreload-polyfill',
  vite:config     'vite:resolve',
  vite:config     'vite:html-inline-script-proxy',
  vite:config     'vite:css',
  vite:config     'vite:esbuild',
  vite:config     'vite:json',
  vite:config     'vite:wasm',
  vite:config     'vite:worker',
  vite:config     'vite:asset',
  vite:config     'vite:define',
  vite:config     'vite:css-post',
  vite:config     'vite:client-inject',
  vite:config     'vite:import-analysis'
  vite:config   ],
  vite:config   build: {
  vite:config     target: [ 'es2019', 'edge88', 'firefox78', 'chrome87', 'safari13.1' ],
  vite:config     polyfillModulePreload: true,
  vite:config     outDir: 'dist',
  vite:config     assetsDir: 'assets',
  vite:config     assetsInlineLimit: 4096,
  vite:config     cssCodeSplit: true,
  vite:config     cssTarget: [ 'es2019', 'edge88', 'firefox78', 'chrome87', 'safari13.1' ],
  vite:config     sourcemap: false,
  vite:config     rollupOptions: {},
  vite:config     minify: 'esbuild',
  vite:config     terserOptions: {},
  vite:config     write: true,
  vite:config     emptyOutDir: null,
  vite:config     manifest: false,
  vite:config     lib: false,
  vite:config     ssr: false,
  vite:config     ssrManifest: false,
  vite:config     reportCompressedSize: true,
  vite:config     chunkSizeWarningLimit: 500,
  vite:config     watch: null,
  vite:config     commonjsOptions: { include: [Array], extensions: [Array] },
  vite:config     dynamicImportVarsOptions: { warnOnError: true, exclude: [Array] }
  vite:config   },
  vite:config   preview: {
  vite:config     port: undefined,
  vite:config     strictPort: undefined,
  vite:config     host: undefined,
  vite:config     https: undefined,
  vite:config     open: undefined,
  vite:config     proxy: undefined,
  vite:config     cors: undefined
  vite:config   },
  vite:config   env: { BASE_URL: '/', MODE: 'development', DEV: true, PROD: false },
  vite:config   assetsInclude: [Function: assetsInclude],
  vite:config   logger: {
  vite:config     hasWarned: false,
  vite:config     info: [Function: info],
  vite:config     warn: [Function: warn],
  vite:config     warnOnce: [Function: warnOnce],
  vite:config     error: [Function: error],
  vite:config     clearScreen: [Function: clearScreen],
  vite:config     hasErrorLogged: [Function: hasErrorLogged]
  vite:config   },
  vite:config   createResolver: [Function: createResolver]
  vite:config } +5ms
  vite:deps Hash is consistent. Skipping. Use --force to override. +0ms

  vite v2.7.0-beta.2 dev server running at:

  > Local: http://localhost:3000/
  > Network: use `--host` to expose

  ready in 444ms.

  vite:spa-fallback Not rewriting GET / because the client did not send an HTTP accept header. +0ms
  vite:time 2.70ms / +0ms
  vite:spa-fallback Rewriting GET / to /index.html +429ms
  vite:time 21.50ms /index.html +449ms
  vite:resolve 3.00ms /@vite/client -> /home/projects/vite-a7kdqq/node_modules/vite/dist/client/client.mjs +0ms
  vite:resolve 0.70ms /main.js -> /home/projects/vite-a7kdqq/main.js +6ms
  vite:load 1.40ms [fs] /main.js +0ms
  vite:load 7.30ms [fs] /@vite/client +1ms
  vite:resolve 1.00ms ./expect-setup -> /home/projects/vite-a7kdqq/expect-setup.js +11ms
  vite:resolve 3.40ms /expect-setup.js -> /home/projects/vite-a7kdqq/expect-setup.js +3ms
  vite:resolve 0.00ms @testing-library/jest-dom -> /home/projects/vite-a7kdqq/node_modules/.vite/@testing-library_jest-dom.js?v=173e7619&es-interop +2ms
  vite:resolve 2.50ms @vite/env -> /home/projects/vite-a7kdqq/node_modules/vite/dist/client/env.mjs +0ms
  vite:resolve 1.00ms /node_modules/.vite/@testing-library_jest-dom.js?v=173e7619&es-interop -> /home/projects/vite-a7kdqq/node_modules/.vite/@testing-library_jest-dom.js?v=173e7619&es-interop +1ms
  vite:resolve 1.20ms /node_modules/vite/dist/client/env.mjs -> /home/projects/vite-a7kdqq/node_modules/vite/dist/client/env.mjs +1ms
  vite:resolve 1.00ms ./style.css -> /home/projects/vite-a7kdqq/style.css +3ms
  vite:import-analysis 10.20ms [1 imports rewritten] node_modules/vite/dist/client/client.mjs +0ms
  vite:resolve 0.90ms /style.css -> /home/projects/vite-a7kdqq/style.css +1ms
  vite:transform 13.10ms /@vite/client +0ms
  vite:time 47.60ms /@vite/client +63ms
  vite:resolve 0.50ms /node_modules/.vite/@testing-library_jest-dom.js?v=173e7619 -> /home/projects/vite-a7kdqq/node_modules/.vite/@testing-library_jest-dom.js?v=173e7619 +21ms
  vite:import-analysis 35.90ms [3 imports rewritten] main.js +24ms
  vite:transform 40.90ms /main.js +22ms
  vite:time 47.80ms /main.js +9ms
  vite:load 9.80ms [fs] /node_modules/vite/dist/client/env.mjs +50ms
  vite:load 4.50ms [fs] /expect-setup.js +0ms
  vite:load 4.80ms [fs] /style.css +0ms
  vite:import-analysis 1.30ms [no imports] node_modules/vite/dist/client/env.mjs +14ms
  vite:resolve 0.10ms expect -> /home/projects/vite-a7kdqq/node_modules/.vite/expect.js?v=173e7619&es-interop +16ms
  vite:transform 4.50ms /node_modules/vite/dist/client/env.mjs +15ms
  vite:resolve 0.50ms /node_modules/.vite/expect.js?v=173e7619&es-interop -> /home/projects/vite-a7kdqq/node_modules/.vite/expect.js?v=173e7619&es-interop +2ms
  vite:resolve 0.60ms /node_modules/.vite/expect.js?v=173e7619 -> /home/projects/vite-a7kdqq/node_modules/.vite/expect.js?v=173e7619 +2ms
  vite:import-analysis 5.60ms [1 imports rewritten] expect-setup.js +4ms
  vite:transform 8.50ms /expect-setup.js +4ms
  vite:load 19.40ms [fs] /node_modules/.vite/@testing-library_jest-dom.js?v=173e7619 +15ms
  vite:resolve 0.40ms ./chunk-XMM2ENDR.js -> /home/projects/vite-a7kdqq/node_modules/.vite/chunk-XMM2ENDR.js +20ms
  vite:resolve 0.50ms /node_modules/.vite/chunk-XMM2ENDR.js?v=173e7619 -> /home/projects/vite-a7kdqq/node_modules/.vite/chunk-XMM2ENDR.js?v=173e7619 +2ms
  vite:import-analysis 13.60ms [1 imports rewritten] node_modules/.vite/@testing-library_jest-dom.js?v=173e7619 +27ms
  vite:transform 14.50ms /node_modules/.vite/@testing-library_jest-dom.js?v=173e7619 +27ms
  vite:load 3.30ms [fs] /node_modules/.vite/chunk-XMM2ENDR.js?v=173e7619 +50ms
  vite:import-analysis 0.60ms [no imports] node_modules/.vite/chunk-XMM2ENDR.js?v=173e7619 +31ms
  vite:transform 1.40ms /node_modules/.vite/chunk-XMM2ENDR.js?v=173e7619 +30ms
  vite:hmr [self-accepts] style.css +0ms
  vite:import-analysis 0.50ms [0 imports rewritten] style.css +9ms
  vite:transform 75.00ms /style.css +9ms
  vite:load 65.70ms [fs] /node_modules/.vite/expect.js?v=173e7619 +13ms
  vite:import-analysis 10.20ms [1 imports rewritten] node_modules/.vite/expect.js?v=173e7619 +21ms
  vite:transform 10.90ms /node_modules/.vite/expect.js?v=173e7619 +22ms
  vite:cache [memory] /node_modules/.vite/chunk-XMM2ENDR.js?v=173e7619 +0ms
  vite:cache [memory] /node_modules/vite/dist/client/env.mjs +2ms
  vite:time 1.70ms /node_modules/vite/dist/client/env.mjs +129ms
  vite:cache [memory] /expect-setup.js +6ms
  vite:cache [memory] /node_modules/.vite/@testing-library_jest-dom.js?v=173e7619 +0ms
  vite:cache [memory] /style.css +0ms
  vite:time 3.60ms /expect-setup.js +5ms
  vite:time 68.90ms /node_modules/.vite/@testing-library_jest-dom.js?v=173e7619 +67ms
  vite:time 147.50ms /style.css +79ms
  vite:cache [memory] /node_modules/.vite/expect.js?v=173e7619 +158ms
  vite:time 54.80ms /node_modules/.vite/expect.js?v=173e7619 +66ms
  vite:cache [memory] /node_modules/.vite/chunk-XMM2ENDR.js?v=173e7619 +243ms
  vite:time 5.30ms /node_modules/.vite/chunk-XMM2ENDR.js?v=173e7619 +193ms


### Validations

- [X] Follow our [Code of Conduct](https://github.com/vitejs/vite/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/vitejs/vite/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://vitejs.dev/guide).
- [X] Check that there isn't [already an issue](https://github.com/vitejs/vite/issues) that reports the same bug to avoid creating a duplicate.
- [X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/vitejs/vite/discussions) or join our [Discord Chat Server](https://chat.vitejs.dev/).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.
@Niputi Niputi added this to the 2.7 milestone Nov 23, 2021
@patak-dev patak-dev added bug p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels Nov 27, 2021
@patak-dev
Copy link
Member

@sodatea I tracked the regression to #5510. Looks like without this change, @testing-library/jest-dom/dist/utils.js interop is using commonjs helpers, and with it, it switches to broken esm helpers.

I see that this PR removed the use of requireOptions here. Maybe the logic to compute the options isn't right?

sodatea added a commit to sodatea/vite that referenced this issue Nov 28, 2021
@sodatea
fix(resolve): should not overwrite isRequire from baseOptions
1750821 
`baseOptions` may already comes with an `isRequire` property.
For example, https://github.com/vitejs/vite/blob/c344865851b1f140f51b2f8d03821419114ac3b9/packages/vite/src/node/optimizer/esbuildDepPlugin.ts#L47-L50 which in turn calls https://github.com/vitejs/vite/blob/c344865851b1f140f51b2f8d03821419114ac3b9/packages/vite/src/node/config.ts#L407-L417

Fixes vitejs#5798
@sodatea sodatea mentioned this issue Nov 28, 2021
Merged
9 tasks
@sodatea
Copy link
Member

sodatea commented Nov 28, 2021

@patak-js fixed in #5872

@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
2.7
Development

Successfully merging a pull request may close this issue.

fix(resolve): dont overwrite isRequire from baseOptions sodatea/vite
4 participants
@patak-dev @sodatea @IanVS @Niputi