SSR can't resolve builtin modules that start with underscore

[cyco130]

Describe the bug

Some packages (like @prisma/client) require the builtin _http_common module (or others that start with an underscore) which causes ssrLoadModule to throw Error: Cannot find module '_http_common' imported from ... error. It seems to be caused by the builtin-modules package that Vite uses for this purpose filtering out modules that start with an underscore (changing the relevant regex in the transpiled code fixes the problem).

Reproduction

• Clone the repo and install the dependencies: https://github.com/cyco130/vite-ssr-http-common-issue
• node ssr-module.mjs works but node . throws trying to load the same module with ssrLoadModule.

System Info

System:
    OS: Linux 5.4 Linux Mint 20.2 (Uma)
    CPU: (8) x64 Intel(R) Core(TM) i7-3630QM CPU @ 2.40GHz
    Memory: 1.70 GB / 15.53 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 14.18.1 - /usr/local/bin/node
    Yarn: 1.22.11 - ~/.npm-global/bin/yarn
    npm: 7.24.1 - ~/.npm-global/bin/npm
  Browsers:
    Chrome: 96.0.4664.45
    Firefox: 94.0

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[patak-dev]

See discussion in #5809 (comment) about this issue

[bluwy]

Based on the discussion and the code, I think it had always been a bug in Vite and is not a regression. Unless this used to work in prior Vite versions?

[Niputi]

its mentioned in #5709 that it used to work in 2.6.14

[ygj6]

its mentioned in #5709 that it used to work in 2.6.14

@Niputi No, I tested the above reproduction repo with vite@2.6.14 and got the same error. It is a bug of vite all the time, @bluwy is right.

In addition, I fetched your PR code and re-tested, it has solved the bug. 👍

[bluwy]

I took a look at why @prisma/client is using _http_common, looks like it's used by a dependency called https://github.com/nodejs/undici. From this comment, undici v4 should remove the need for _http_common, so all that's left is for @prisma/client to upgrade to v4, which is not done yet (prisma/prisma#7539). Maybe it's better to wait for the PR in the long term?

[patak-dev]

I think we should add it, it is good that our isBuiltin is in sync with esbuild harcoded list

[cyco130]

Based on the discussion and the code, I think it had always been a bug in Vite and is not a regression. Unless this used to work in prior Vite versions?

I found about this trying to make @prisma/client work with 2.7 (it worked with 2.5 and 2.6). It does work when I fix this so I thought this was a regression. But the repro here doesn't work with 2.5 or 2.6 either (but Prisma does).

I'm not really sure what's going on, maybe some other bug was causing @prisma/client to work on 2.6 when it really shouldn't have because the _http_common import is there :) I don't think it's worth investigating since fixing this makes Prisma work.