Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(json): load json module error #6352

Merged
merged 8 commits into from Mar 3, 2022
Merged

fix(json): load json module error #6352

merged 8 commits into from Mar 3, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Jan 2, 2022

Description

fix #6350

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jan 2, 2022
@poyoho poyoho requested a review from bluwy January 3, 2022 01:37
Shinigami92
Shinigami92 reviewed Jan 3, 2022
View reviewed changes
packages/vite/src/node/plugins/resolve.ts Outdated Show resolved Hide resolved
packages/vite/src/node/plugins/resolve.ts Outdated Show resolved Hide resolved
packages/vite/src/node/plugins/resolve.ts Outdated Show resolved Hide resolved
@praneetloke
Copy link

@poyoho thank you so much for this PR! It'd be awesome to get this over the finish line!

@praneetloke
Copy link

Can this PR be merged now that it's all green?

@Niputi Niputi added this to the 2.9 milestone Feb 5, 2022
@patak-dev patak-dev merged commit c8a7ea8 into vitejs:main Mar 3, 2022
@poyoho poyoho deleted the feat/json-module branch March 3, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
No open projects
Release Plan
Status: Todo
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

tryNodeResolve does not find index.json
6 participants
@poyoho @praneetloke @patak-dev @Shinigami92 @bluwy @Niputi