fix(html): build mode ignore html define transform #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygj6
reviewed
Jan 28, 2022
Co-authored-by: ygj6 <7699524+ygj6@users.noreply.github.com>
bluwy
previously approved these changes
Jan 29, 2022
ygj6
reviewed
Jan 30, 2022
ygj6
previously approved these changes
Jan 30, 2022
patak-dev
added
the
p3-minor-bug
patak-dev
changed the title
|
We discussed this PR today @poyoho and we are going to move forward with it. Thanks for the fix! Let's wait until next week to merge it during the 2.9 beta to get a bit more testing |
|
Is 2.9 coming? |
We plan to start the beta period late next week, and normally we will be in beta for 3-5 weeks. This will be the last 2.x release. April 30th is Node 12 EOL so we will release 3.0 to drop support for it and remove deprecations. |
bluwy
previously approved these changes
Mar 4, 2022
patak-dev
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: #6536
Additional context
exclude html, css and static assets for transform
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).