fix: reoptimize deps on esbuild options change #6855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
added
the
p3-minor-bug
Niputi
changed the title
bluwy
reviewed
Feb 11, 2022
patak-dev
changed the title
bluwy
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: #6853
optimizeDeps.esbuildOptions.pluginswas missing from the main metadatahashof optimized deps. There could be otheresbuildOptionsthat should be added.Adding the
esbuildOptions.pluginsfield to the hash generation will invalidate the caches for every user, even if there aren't plugins. I think that this is a good idea because there could be some caches that are stale and the user doesn't even know right now.Additional context
We don't have currently a test for re-running the optimizer, I don't think is needed for this PR but it would be good to test this path.
What is the purpose of this pull request?