Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reoptimize deps on esbuild options change #6855

Merged
merged 2 commits into from Mar 3, 2022

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Feb 10, 2022

Description

fix: #6853

optimizeDeps.esbuildOptions.plugins was missing from the main metadata hash of optimized deps. There could be other esbuildOptions that should be added.

Adding the esbuildOptions.plugins field to the hash generation will invalidate the caches for every user, even if there aren't plugins. I think that this is a good idea because there could be some caches that are stale and the user doesn't even know right now.

Additional context

We don't have currently a test for re-running the optimizer, I don't think is needed for this PR but it would be good to test this path.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 10, 2022
@Niputi Niputi changed the title fix: reoptimize deps on esbuild plugin change (fix #6853) fix: reoptimize deps on esbuild plugin change Feb 10, 2022
@patak-dev patak-dev requested a review from bluwy March 1, 2022 09:10
@patak-dev patak-dev added this to the 2.9 milestone Mar 1, 2022
@patak-dev patak-dev changed the title fix: reoptimize deps on esbuild plugin change fix: reoptimize deps on esbuild options change Mar 1, 2022
@patak-dev patak-dev merged commit 4517c2b into main Mar 3, 2022
@patak-dev patak-dev deleted the fix/reoptimize-deps-on-esbuild-plugin-change branch March 3, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Change to vite.config.js optimizeDeps does not trigger Pre-bundling of dependencies
2 participants