Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: explicit the word boundary #6876

Merged
merged 6 commits into from Apr 12, 2022
Merged

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Feb 12, 2022

Description

@patak-dev @eugene1g

  1. Do not allow preceding '.', but do allow preceding '...' for spread operations for the import expression
  2. replace comment string and string value to ' ' and the match the import url position

mentioned #7549

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy
bluwy previously approved these changes Feb 13, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat regex tricks.

bluwy
bluwy previously approved these changes Mar 27, 2022
@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Mar 27, 2022
@patak-dev patak-dev merged commit 7ddbf96 into vitejs:main Apr 12, 2022
@poyoho poyoho deleted the fix(html)/re-explicit branch April 13, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants