Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: recycle serve to avoid preventing Node self-exit #6895

Merged
merged 1 commit into from Feb 18, 2022
Merged

fix: recycle serve to avoid preventing Node self-exit #6895

merged 1 commit into from Feb 18, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Feb 13, 2022

Description

fix: #6815

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 15, 2022
bluwy
bluwy approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know this file has a singleton server variable. This change makes sense to me.

@patak-dev patak-dev merged commit d6b2c53 into vitejs:main Feb 18, 2022
@bluwy bluwy mentioned this pull request Mar 30, 2022
Closed
7 tasks
@poyoho poyoho deleted the fix/recycle-serve branch April 26, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Akryum Akryum Akryum approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Memory" leak leading to processes preventing Node self-exit
5 participants
@poyoho @patak-dev @Akryum @bluwy @Niputi