Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot reassign process.env.NODE_ENV in ssr #6989

Merged
merged 9 commits into from Feb 19, 2022
Merged

fix: cannot reassign process.env.NODE_ENV in ssr #6989

merged 9 commits into from Feb 19, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Feb 18, 2022

Description

fix: #6975
mentioned: #6970

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-dev
patak-dev previously approved these changes Feb 19, 2022
View reviewed changes
@patak-dev patak-dev requested a review from bluwy February 19, 2022 13:12
bluwy
bluwy reviewed Feb 19, 2022
View reviewed changes
packages/vite/src/node/plugins/define.ts Outdated Show resolved Hide resolved
packages/vite/src/node/plugins/define.ts Outdated Show resolved Hide resolved
@bluwy bluwy changed the title fix: cannot reassign procces.env.NODE_ENV in ssr fix: cannot reassign process.env.NODE_ENV in ssr Feb 19, 2022
@patak-dev patak-dev merged commit 983feb2 into vitejs:main Feb 19, 2022
@poyoho poyoho deleted the fix/reassign-ssr branch February 20, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox left review comments

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot reassign procces.env.NODE_ENV in ssr
4 participants
@poyoho @patak-dev @frandiox @bluwy