New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent loading env outside of root #6995
Conversation
is the new option really needed? it looks like a case which was not accounted for in implementation. |
Yeah I don't think it's needed too. We could remove it and disclose as a "bug fix", but it feels like it could be a breaking change so I played it safe here. Definitely open for discussion though. |
Been thinking about it and I think it makes sense to just remove the option. I don't see a usecase where someone intend to load |
To play safe, let's merge this one in the 2.9 beta period (I think we should start it in a week from now). |
Should we add a note to the docs? |
I think the docs are fine right now with "The directory from which |
Description
Fixes #6933
Fixes #5712
Loading env files will only load from the
envDir
only, anything above the directory is not checked.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).