Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't override user config #7034

Merged
merged 1 commit into from Feb 23, 2022
Merged

fix: don't override user config #7034

merged 1 commit into from Feb 23, 2022

Conversation

otakustay
Copy link
Contributor

Description

The incoming inlineConfig may be frozen and Object.assign may fail for object is not extensible error.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy
bluwy previously approved these changes Feb 22, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did a check and it seems like there's no other code relying on this mutation.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Feb 22, 2022
The incoming `inlineConfig` may be frozen and `Object.assign` may fail for `object is not extensible` error.
@patak-dev patak-dev merged commit 8fd8f6e into vitejs:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants