feat(perf): tsconfck perf improvement #7055
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tsconfck 1.1.0 always traverses the parent directories for each code file to find the closest tsconfig.json, needlessly calling fs.stat multiple times.
Initial report here: #7023
tsconfck 1.2.0 gained new options to avoid this by providing a pre-composed list of tsconfig paths that is used instead of the actual filesystem.
This is a potentially breaking change because to be able to provide a complete list of tsconfig files, a root directory has to be set. This PR uses the detected workspace root which should cover most real project setups.
But still it is possible that someone somewhere uses a tsconfig.json outside their workspace root and they will see an error after this is merged
Additional context
for performance reasons, tsconfig.json files are not searched in
node_modules
or.git
directories. Again this could be breaking if someone had something likesrc/node_modules/tsconfig.json
or somehow used ts files and an acccompanying tsconfig directly from an npm package.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).