fix: import with query with exports/browser field #7098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
bluwy
approved these changes
Feb 26, 2022
bluwy
requested changes
Feb 26, 2022
sapphi-red
changed the title
bluwy
reviewed
Mar 9, 2022
| @@ -772,7 +777,7 @@ function packageEntryFailure(id: string, details?: string) { | |||
|
|
|||
| function resolveExports( | |||
| pkg: PackageData['data'], | |||
| key: string, | |||
| keyWithQuery: string, | |||
There was a problem hiding this comment.
I think it's nice if we can leave this back as key
7 tasks
|
Friendly poke to merge 🙇. Is there anything left after approval? |
patak-dev
approved these changes
Mar 29, 2022
sapphi-red
added a commit
to sapphi-red/web-noise-suppressor
that referenced
this pull request
Mar 30, 2022
MadLittleMods
added a commit
to element-hq/hydrogen-web
that referenced
this pull request
Apr 5, 2022
Update to Vite which includes vitejs/vite#7098
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous PR (#7073) did fix for cases like
.png?urlwhich becomes url regardless of?url, but did not work with other cases.This PR fix for those. For example,
.json?url,.wasm?url. (I overlooked.json?urlwas broken...)fix #6725
fix #7281
Additional context
refs #7097
Thanks @MadLittleMods for mentioning.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).