Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Warn about terserOptions in more cases #7101

Merged
merged 1 commit into from Feb 27, 2022

Conversation

mvolfik
Copy link
Contributor

@mvolfik mvolfik commented Feb 26, 2022

Until now, the warning wasn't issued when build.minify wasn't set (i.e. the value was undefined), but in the end the config defaulted to esbuild

Description

Additional context

Related to #5041


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Until now, the warning wasn't issued when build.minify wasn't set (i.e. the value was `undefined`), but in the end the config defaulted to esbuild
@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Feb 26, 2022
@patak-dev patak-dev merged commit 79428ad into vitejs:main Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants