Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw Error when can't preload CSS #7108

Merged
merged 3 commits into from Mar 1, 2022

Conversation

sheremet-va
Copy link
Member

Closes #7107

haneenmahd
haneenmahd previously approved these changes Feb 27, 2022
Copy link

@haneenmahd haneenmahd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR provides a more meaningful logs if css is failed to load

packages/vite/src/node/plugins/importAnalysisBuild.ts Outdated Show resolved Hide resolved
@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) feat: css and removed feat: css labels Feb 28, 2022
VinVC
VinVC previously approved these changes Mar 1, 2022
@bluwy bluwy added the feat: css label Mar 1, 2022
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@sheremet-va sheremet-va dismissed stale reviews from VinVC and haneenmahd via 276fac1 March 1, 2022 16:36
@patak-dev patak-dev merged commit d9f8edb into vitejs:main Mar 1, 2022
sinoon pushed a commit to sinoon/vite that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw Error instead of Event, when not able to load CSS
5 participants