Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update watch mode #7132

Merged
merged 6 commits into from Apr 11, 2022
Merged

fix: update watch mode #7132

merged 6 commits into from Apr 11, 2022

Conversation

Bigfish8
Copy link
Contributor

@Bigfish8 Bigfish8 commented Mar 1, 2022

Description

fix #6907. #7395
Now vite use rollup.watch in watch mode.And rollup.watch use resolveId to locate file.
Now vite resolve id with query (eg: ?raw for external and ?used for internal).It will break file watching.
So add a plugin to help watching file.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi added the p3-minor-bug An edge case that only affects very specific usage (priority) label Mar 2, 2022
bluwy
bluwy previously approved these changes Mar 4, 2022
bluwy
bluwy previously approved these changes Mar 27, 2022
@bluwy
Copy link
Member

bluwy commented Mar 27, 2022

Looks like there are some changes to the jest setup file that needs to be resolved, but the core changes sounds fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite build --watch does not trigger reload when imported Sass module changes
4 participants