Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #6340, definePlugin tests, warning box #7174

Merged
merged 3 commits into from Mar 4, 2022

Conversation

dominikg
Copy link
Contributor

@dominikg dominikg commented Mar 4, 2022

Description

This #6340 introduced changes to the definePlugin that broke ecosystem-ci tests of 2.9-beta for svelte due to changes how it replaces import.meta.env.SSR

see https://discord.com/channels/804011606160703521/949170949117313085

Steps to take:

  • add a testsuite that ensures import.meta.env replacements are working as expected
  • rollback the og change pr to get them passing
  • discuss what kind of changes/improvements we want to make in 2.9

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev changed the title fix: definePlugin fix: revert #6340, definePlugin tests, warning box Mar 4, 2022
@patak-dev patak-dev merged commit 6cb0647 into vitejs:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants