Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add hash to lib chunk names #7190

Merged
merged 3 commits into from May 11, 2022
Merged

fix: add hash to lib chunk names #7190

merged 3 commits into from May 11, 2022

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Mar 6, 2022

Description

Added the hash to file names of lib chunks and assets, to avoid name confliction when using dynamic imports

Closes #8120


Update: The asset name can't be modified currently because style.css is the hard-code name for lib. Perhaps we should add an option to customize this name in the future


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@pd4d10 pd4d10 changed the title fix: add hash to lib chunks and assets fix: add hash to lib chunk names Mar 6, 2022
@patak-dev
Copy link
Member

Would you provide a reproduction of the issue this PR is solving?

@pd4d10
Copy link
Contributor Author

pd4d10 commented May 11, 2022

Would you provide a reproduction of the issue this PR is solving?

OK, I'll submit an issue with a reproduction later.

@pd4d10
Copy link
Contributor Author

pd4d10 commented May 11, 2022

Submitted #8120 to provide a reproduction link

@patak-dev patak-dev merged commit c81cedf into vitejs:main May 11, 2022
@pd4d10 pd4d10 deleted the patch-5 branch May 11, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lib mode] name confliction when using dynamic imports
4 participants