Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate { assert: { type: raw }} in favor of { as: raw } (fix #7017) #7215

Merged
merged 5 commits into from Mar 8, 2022

Conversation

brillout
Copy link
Contributor

@brillout brillout commented Mar 7, 2022

Description

Implements the following comment in #7017.

We talked about this PR and we think we should add { as: 'raw' } for glob import marked as experimental in Vite 2.9 and deprecate the { assert: { type: 'raw' }} syntax. We can then remove the assert syntax in Vite 3.0 at the beginning of May.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

 vitejs#7017)

BREAKING CHANGE: Use `import.meta.globEager('/dir/*.js', { as: 'raw' })` instead of `import.meta.globEager('/dir/*.js', { assert: { type: 'raw' } })` (it will be deprecated in Vite 3.0).
patak-dev
patak-dev previously approved these changes Mar 7, 2022
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @brillout!

Shinigami92
Shinigami92 previously approved these changes Mar 7, 2022
patak-dev
patak-dev previously approved these changes Mar 7, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to update the docs too: https://vitejs.dev/guide/features.html#glob-import

@brillout
Copy link
Contributor Author

brillout commented Mar 8, 2022

We may want to update the docs too: https://vitejs.dev/guide/features.html#glob-import

👍 Done

@patak-dev patak-dev merged commit 87ecce5 into vitejs:main Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants