Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): hmr style tag no support in html #7262

Merged
merged 1 commit into from Mar 14, 2022

Conversation

poyoho
Copy link
Member

@poyoho poyoho commented Mar 11, 2022

Reverts #7136

I think this can revert before 2.9 release

@poyoho poyoho changed the title Revert "fix: revert #7052, hmr style tag no support in html" revert: fix: revert #7052, hmr style tag no support in html Mar 11, 2022
@poyoho poyoho changed the title revert: fix: revert #7052, hmr style tag no support in html revert: hmr style tag no support in html Mar 11, 2022
@Niputi Niputi changed the title revert: hmr style tag no support in html fix(hmr): hmr style tag no support in html Mar 13, 2022
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poyoho @IanVS so IIUC storybook vite builder has now rework their issue with #7052 and it is safe to include it back as part of the beta, no?

@poyoho
Copy link
Member Author

poyoho commented Mar 14, 2022

I think yes.

@IanVS
Copy link
Contributor

IanVS commented Mar 14, 2022

Yes I think it should be fine to move forward with it. Thanks for checking.

@patak-dev patak-dev merged commit fae120a into vitejs:main Mar 14, 2022
@poyoho poyoho deleted the revert-7136-fix/revert-7052 branch March 14, 2022 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants