fix: dep with dynamic import wrong error log #7313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging so we can release a quick patch now that we asked people to try it out. |
bluwy
reviewed
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a test case to showcase the issue. The comment in the code explains why this isn't an error. These dynamic imports are of the form
OriginalFileName-{hash}.js.I think later we could save in the metadata the names of all non-entry outputs, chunks, and dynamic imports, so we can do these checks against the real file names.
Reproduction with 2.9-beta.1 here: https://stackblitz.com/edit/vitejs-vite-kvca58
What is the purpose of this pull request?