Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): server restart on config dependencies changed on windows #7366

Merged
merged 2 commits into from Mar 20, 2022
Merged

fix(config): server restart on config dependencies changed on windows #7366

merged 2 commits into from Mar 20, 2022

Conversation

sapphi-red
Copy link
Member

Description

Server was not restarting when config dependencies was changed on windows.
This PR fixes this.

refs #3031

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy
bluwy previously approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me. Looks like file was initially normalized here

ydcjeff
ydcjeff previously approved these changes Mar 18, 2022
View reviewed changes
@patak-dev
Copy link
Member

I think that we should directly normalize these paths when resolving the config. Check that we are already doing so for other paths.

@sapphi-red sapphi-red dismissed stale reviews from ydcjeff and bluwy via 974c059 March 20, 2022 03:42
@sapphi-red
Copy link
Member Author

I think that is better. I have changed it!

@sapphi-red sapphi-red requested a review from bluwy March 20, 2022 03:46
@patak-dev patak-dev merged commit c43467a into vitejs:main Mar 20, 2022
@sapphi-red sapphi-red deleted the fix/config-dependency-restart-windows branch March 20, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@ydcjeff ydcjeff ydcjeff approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sapphi-red @patak-dev @ydcjeff @bluwy