Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid mangling code from incorrect magic-string usage #7397

Merged
merged 1 commit into from Mar 21, 2022

Conversation

benmccann
Copy link
Collaborator

Description

Fixes #7365

The current default in magic-string seems like a bit of a footgun. Until / unless the default is changed (Rich-Harris/magic-string#211), we should manually specify contentOnly: true

Additional context

This is causing difficult to diagnose errors in SvelteKit with SvelteKit itself giving errors like "Method not allowed" due to incorrectly compiled .js files


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann added bug p3-minor-bug An edge case that only affects very specific usage (priority) labels Mar 21, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think there are places where we'd expect the contentOnly: false behaviour. And the tests passed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR transform loses Object.defineProperty in certain cases
3 participants